Correct Fact mysqld_version on FreeBSD #1654
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapouik
requested review from
alexjfisher,
bastelfreak and
a team
as code owners
|
Philippe BEAUMONT seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
bastelfreak
reviewed
Oct 25, 2024
| @@ -1,9 +1,9 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| Facter.add('mysqld_version') do | |||
| confine { Facter::Core::Execution.which('mysqld') || Facter::Core::Execution.which('/usr/libexec/mysqld') } | |||
| confine { Facter::Core::Execution.which('mysqld') || Facter::Core::Execution.which('/usr/libexec/mysqld') || Facter::Core::Execution.which('/usr/local/libexec/mysqld') } | |||
There was a problem hiding this comment.
mhm this becomes a bit messy. Do you know if we can set PATH for the which() method? Or is it a bug that it doesn't already check in /usr/libexec/?
There was a problem hiding this comment.
I don't know if there is a better way like setting a PATH before. If someone find a proper solution : that's ok to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Actually, the fact mysqld_version don't work on FreeBSD.
Additional Context
FreeBSD install package in /usr/local. So mysqld is in /usr/local/libexec and the fact only look in /usr/libexec and PATH.
Checklist
puppet apply)